[MNT] add wheel-based dataset test to CI, closes #423#512
Closed
sohamjadhav95 wants to merge 2 commits into
Closed
[MNT] add wheel-based dataset test to CI, closes #423#512sohamjadhav95 wants to merge 2 commits into
sohamjadhav95 wants to merge 2 commits into
Conversation
Author
|
The two failures are pre-existing and unrelated to this PR: code-quality failed due to a transient GitHub API outage in setup-uv@v7 — re-running resolves this Neither failure is introduced by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #423
What this does
Adds a
test-wheelCI job toci.ymlthat:pygam/tests/test_datasets.pyto verify all CSV dataset loaders work from a packaged installWhy this is needed
The packaging fix was applied in #424 (
**/*.csvglob inpyproject.toml) and wheel-based tests were added topypi.ymlin #425 for release time. However, the regularci.ymltest job installs withpip install -e ".[dev]"(editable mode), which reads files directly from the source tree — meaning a packaging regression would pass CI on every PR but break at release.This PR closes the gap by catching packaging regressions on every PR, not just at release.
Testing